[PATCH] D148618: [SCEV] Support sub in and negative constants willNotOverflow

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:2372
+    return isKnownPredicateAt(Pred, getConstant(Limit), LHS, CtxI);
+  } else {
+    // To avoid overflow up, we need to make sure that LHS <= MAX - Magnitude
----------------
mkazantsev wrote:
> dmakogon wrote:
> > You don't need this `else` after return
> Indeed.
I just want to keep it that way because it is so perfectly aligned one under one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148618/new/

https://reviews.llvm.org/D148618