[PATCH] D147172: [OpenMP][Flang][MLIR] Add lowering of TargetOp for host codegen

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 02:22:09 PDT 2023


kiranchandramohan added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:460
+                                     /* OpenMPOffloadMandatory */ false);
+  getOpenMPBuilder()->setConfig(Config);
 }
----------------
This will always create the OpenMPIRBuilder, even for non-OpenMP flows which is not what we want.

`getOpenMPBuilder` creates the Builder if it is not yet created. We can consider setting the config there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147172/new/

https://reviews.llvm.org/D147172



More information about the llvm-commits mailing list