[PATCH] D149049: [AMDGPU][Disassembler] Fix a spurious error message in an instruction comment.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 01:27:18 PDT 2023


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

I guess this OK as it fixes a bug, but I'd be happier if we had a plan for what to do with these error messages.

> Shouldn't error messages not get written to the comment stream in the first place? It seems like you're just trying to avoid getting them in the final output

I think we want error messages if decoding fails, but not from a failed attempt that was followed by a successful attempt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149049/new/

https://reviews.llvm.org/D149049



More information about the llvm-commits mailing list