[PATCH] D149091: [Object] Recognize ARM64EC binaries in COFFObjectFile::getMachine.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 00:55:43 PDT 2023


jhenderson added a comment.

In D149091#4293527 <https://reviews.llvm.org/D149091#4293527>, @efriedma wrote:

> Is it possible to write tests using yaml2obj instead of lld-link?

+1 to this if at all possible: the code under test isn't LLD specific (I assume, since it's in the LLVM header area), so sticking the testing in lld seems wrong. It might require some extra work in yaml2obj to get it to support new things, but I don't think that's a bad thing.



================
Comment at: lld/test/COFF/arm64ec.test:43
+DISAS-NEXT: ...
+
+
----------------
Nit: delete extra blank line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149091/new/

https://reviews.llvm.org/D149091



More information about the llvm-commits mailing list