[PATCH] D145634: [X86] Support llvm.{min,max}imum.f{16,32,64}

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.

LGTM



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:30329
+    return MinMax;
+  }
+
----------------
(style) remove braces from single line if()


================
Comment at: llvm/test/CodeGen/X86/fminimum-fmaximum.ll:120
+;
+; AVX-LABEL: test_fmaximum_scalarize:
+; AVX:       # %bb.0:
----------------
skatkov wrote:
> Here is what I mentioned in terms of non-optimial vectorized version at least on AVX.
For now we just want x86 to support the intrinsics, vector optimization is better handled as a followup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145634/new/

https://reviews.llvm.org/D145634