[PATCH] D148986: [InstSimplify] with logical ops: (X | Y) ? 0 : X --> 0

Mon Apr 24 19:52:22 PDT 2023

Allen marked 2 inline comments as done.
Allen added a comment.

In D148986#4292300 <https://reviews.llvm.org/D148986#4292300>, @nikic wrote:

> Implementation looks good, can you please precommit the tests?

Thanks, apply your comment. Precommit the tests on D149115 <https://reviews.llvm.org/D149115>, and also add negative  case with **icmp constant is not zero** as suggestion.

================
Comment at: llvm/test/Transforms/InstSimplify/select-cmp-or.ll:33
+;
+  %a = mul i32 %a0, 43         ; thwart complexity-based canonicalization
+  %or = or i32 %a, %b
----------------
nikic wrote:
> Not needed for instsimplify tests.
Delete the **thwart complexity-based canonicalization**

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148986/new/

https://reviews.llvm.org/D148986