[PATCH] D148674: ValueTracking: Handle frem in computeKnownFPClass
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 24 16:01:25 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4686
if (KnownLHS.isKnownNever(fcNegative) && KnownRHS.isKnownNever(fcNegative))
Known.knownNot(fcNegative);
----------------
foad wrote:
> This part only works for FDiv. I can't think of anything useful you can prove about the sign of FRem.
"the result has the same sign as x and magnitude less than the magnitude of y."
So actually this is more conservative than required for free
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148674/new/
https://reviews.llvm.org/D148674
More information about the llvm-commits
mailing list