[PATCH] D144084: [LLD] [COFF] Don't try to detect MSVC installations in mingw mode

Mon Apr 24 15:43:19 PDT 2023

mati865 added a comment.

In D144084#4140722 <https://reviews.llvm.org/D144084#4140722>, @mstorsjo wrote:

> I'm not sure what would be best here - add a more specific `-tolerate-duplicate-weak-sybols` option or something like that? Or add a more specific flag, always passed by default by the mingw driver frontend, e.g. `-detect-msvc:no`?

Sorry if you have been waiting for me, this has slipped under my radar.
I don't know MSVC at all so I cannot provide any suggestions there but for MinGW any way that disables MSVC search by the default probably would be beneficial.

In D144084#4134321 <https://reviews.llvm.org/D144084#4134321>, @mstorsjo wrote:

> I had to revert this, as it broke one test in compiler-rt/test/profile/Windows/coverage-weak-lld.cpp, which relied on linking in an MSVC environment (finding the lib path from the environment) with `-lldmingw` to opt in to mingw style behaviours.

I was under impression lld-link should follow MSVC closely (so this behaviour would be surprising) but that might just a wrong impression from a bystander.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144084/new/

https://reviews.llvm.org/D144084