[PATCH] D148655: ValueTracking: Handle powi in computeKnownFPClass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 15:39:41 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4479-4481
+        if (KnownSrc.cannotBeOrderedLessThanZero() &&
+            KnownSrc.isKnownNeverNegZero())
+          Known.knownNot(KnownFPClass::OrderedLessThanZeroMask);
----------------
arsenm wrote:
> foad wrote:
> > I think this simplifies to:
> > ```
> >   if (KnownSrc.isKnownNot(fcNegative))
> >     Known.knownNot(fcNegative);
> > ```
> I was trying to avoid handling the denormals flush case but I think a mode check is still needed. 
don't think denormal matters after all


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148655/new/

https://reviews.llvm.org/D148655



More information about the llvm-commits mailing list