[PATCH] D141077: [MemProf] Context disambiguation cloning pass [patch 3/3]

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.
Herald added a subscriber: hoy.

In D141077#4282228 <https://reviews.llvm.org/D141077#4282228>, @snehasish wrote:

> Still need to look into `assignFunctions` but before I do I'm wondering if this patch can be split into two with `applyImport` and `assignFunctions` in separate patches. What do you think?

Yes, looks like it will be straightforward to remove that part (which also means removing a few tests and a few changes to other files). What I will do is update this patch with the rebased version (on top of the committed patch 2). Then I will address the 1 comment that I see that is in the ThinLTO backend specific handling, so we don't lose that. Then I will strip out the ThinLTO backend code from here, in preparation for moving it to another patch, and finally, I will address the rest of your comments. I'll let you know when it is ready to re-review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141077/new/

https://reviews.llvm.org/D141077