[PATCH] D148966: [SLP] Cleanup: Remove loop around `tryToVectorizeSequence` of PHIs.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 14:39:15 PDT 2023


ABataev added a comment.

In D148966#4293758 <https://reviews.llvm.org/D148966#4293758>, @vporpo wrote:

>> Why not complete? Removing this may affect vectorization. If you mean to the test, I can try to add it.
>
> It is not complete in the sense that this is just for PHIs and is not supported for other seeds.
>
> It just seems to me that this shouldn't have too much impact, and it is better to have the same logic for all seed types. If we really need this feature we should either enable it for all or completely remove it.

The fact that it is not ready for other seeds, does not make it non-important for PHIs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148966/new/

https://reviews.llvm.org/D148966



More information about the llvm-commits mailing list