[PATCH] D149100: [AA] Skip the layer of indirection in returning conservative results.

David Goldblatt via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 14:23:43 PDT 2023


davidtgoldblatt created this revision.
davidtgoldblatt added a reviewer: nikic.
Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, jeroen.dobbelaere, foad, StephenFan, kerbowa, hiraditya, jvesely, arsenm.
Herald added a project: All.
davidtgoldblatt requested review of this revision.
Herald added subscribers: llvm-commits, jholewinski.
Herald added a project: LLVM.

Historically, AA implementations chained to a following implementation
to answer recursive queries. This is no longer the case, but the legacy
lives on in a confusing phrasing of the return-a-conservative-value
paths. Let's just return "don't know" directly, where appropriate; the
current two-step way is confusing.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149100

Files:
  llvm/lib/Analysis/BasicAliasAnalysis.cpp
  llvm/lib/Analysis/GlobalsModRef.cpp
  llvm/lib/Analysis/ObjCARCAliasAnalysis.cpp
  llvm/lib/Analysis/ScalarEvolutionAliasAnalysis.cpp
  llvm/lib/Analysis/ScopedNoAliasAA.cpp
  llvm/lib/Analysis/TypeBasedAliasAnalysis.cpp
  llvm/lib/Target/AMDGPU/AMDGPUAliasAnalysis.cpp
  llvm/lib/Target/NVPTX/NVPTXAliasAnalysis.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149100.516531.patch
Type: text/x-patch
Size: 11970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230424/ac1452a3/attachment.bin>


More information about the llvm-commits mailing list