[PATCH] D149021: [TTI][ASAN] Introduce TTI::getInterestingMemoryOperand.

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 12:53:01 PDT 2023


kparzysz added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:889
+  // Return InterestingMemoryOperand of Intrinsic \p II.
+  InterestingMemoryOperand getInterestingMemoryOperand(IntrinsicInst *II) const;
+
----------------
fakepaper56 wrote:
> kparzysz wrote:
> > The term "interesting" is meaningless in this context.  We should use more descriptive names in files that are shared among multiple users.
> I am bad at naming. Do you think MemoryRefInfo is a good new name?
Sounds a lot better to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149021/new/

https://reviews.llvm.org/D149021



More information about the llvm-commits mailing list