[PATCH] D148516: [TableGen] Emit separate computeRequiredFeatures() function

[Pavel Kosov via Phabricator via llvm-commits]

kpdev42 marked an inline comment as done.
kpdev42 added inline comments.


================
Comment at: llvm/utils/TableGen/InstrInfoEmitter.cpp:748
   // Emit the available features compute function.
+  OS << "static ";
   SubtargetFeatureInfo::emitComputeAssemblerAvailableFeatures(
----------------
courbet wrote:
> Won't this force emitting a copy in each compilation unit that includes the generated file ? Using `inline` instead would allow deduping the symbol.
Changed (here and in `computeRequiredFeatures`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148516/new/

https://reviews.llvm.org/D148516