[PATCH] D143180: DAG: Expand legalization of is.fpclass to fcmp for DAZ

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 12:03:33 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:8060
   if (Flags.hasNoFPExcept() &&
+      // TODO: Should check isCondCodeLegal
       isOperationLegalOrCustom(ISD::SETCC, OperandVT.getScalarType())) {
----------------
sepavloff wrote:
> What prevents to put the check here?
Expanded logic which I have no way of testing. If I can't write a test I'm not writing the handling for it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143180/new/

https://reviews.llvm.org/D143180



More information about the llvm-commits mailing list