[PATCH] D149080: [AMDGPU] Fix negative offset values interpretation in getMemOperandsWithOffset for DS
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 24 11:54:28 PDT 2023
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:332-333
- unsigned Offset0 = Offset0Op->getImm();
- unsigned Offset1 = Offset1Op->getImm();
+ APInt Offset0(8, Offset0Op->getImm());
+ APInt Offset1(8, Offset1Op->getImm());
if (Offset0 + 1 != Offset1)
----------------
Don't need to involve APInt? Just use int64_t like every imm operand really is
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149080/new/
https://reviews.llvm.org/D149080
More information about the llvm-commits
mailing list