[PATCH] D149016: [TableGen] Make defvar prior to class template arguments

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM with a test nit.



================
Comment at: llvm/test/TableGen/defvar.td:153
+// CHECK: def shadowTemplateArg {
+// CHECK-NEXT: int value = 10;
+defm shadowTemplateArg: MulticlassShadowTest<2, 3, 3>;
----------------
Can we make the checks more granular? While the failure here will catch the problem, it will be hard to tell which part, exactly got broken.

Having an individual test for each of the shadowing scenarious would be useful, IMO.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149016/new/

https://reviews.llvm.org/D149016