[PATCH] D147544: [BOLT] Move from RuntimeDyld to JITLink

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 11:13:42 PDT 2023


rafauler added inline comments.


================
Comment at: bolt/lib/Rewrite/ExecutableFileMemoryManager.cpp:34
+  });
+  return std::move(Sections);
+}
----------------
Some warnings from clang here:

ExecutableFileMemoryManager.cpp:34:10: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
  return std::move(Sections);
         ^
ExecutableFileMemoryManager.cpp:34:10: note: remove std::move call here
  return std::move(Sections);


================
Comment at: bolt/lib/Rewrite/JITLinkLinker.cpp:191
+  });
+  return std::move(Blocks);
+}
----------------
some warning from clang here:

JITLinkLinker.cpp:191:10: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
  return std::move(Blocks);
         ^
note: remove std::move call here
  return std::move(Blocks);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147544/new/

https://reviews.llvm.org/D147544



More information about the llvm-commits mailing list