[PATCH] D143369: [llvm-profdata] Fix bug llvm-profdata crashes when reading a text sample profile with an empty line with spaces.

[William Junda Huang via Phabricator via llvm-commits]

huangjd added a comment.

In D143369#4292062 <https://reviews.llvm.org/D143369#4292062>, @ro wrote:

> A reghunt just determined that this patch broke a considerable number (30+) of profile-related tests on Solaris/sparcv9.  E.g.
>
>   +  LLVM :: Other/new-pm-thinlto-prelink-samplepgo-inline-threshold.ll
>   
>   /vol/llvm/src/llvm-project/dist/llvm/test/Other/new-pm-thinlto-prelink-samplepgo-inline-threshold.ll:74:10: error: CHECK: expected string not found in input
>   ; CHECK: call i32 @_Z4sum1ii
>            ^
>
> I just noticed this again when switching host compiler of the 1-stage clang-solaris-sparcv9 buildbot from llvm 15.0.0 to 16.0.0.
>
> Should we discuss this here or is it better to file an Issue?

Could you discuss this with more detail? This patch is very simple to understand so I am surprised that it's causing such a bug


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143369/new/

https://reviews.llvm.org/D143369