[PATCH] D147892: [VPlan] Unify Value2VPValue and VPExternalDefs maps (NFCI).
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 24 09:52:00 PDT 2023
fhahn marked an inline comment as done.
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:2334
void addVPValue(Value *V, VPValue *VPV) {
- assert(Value2VPValueEnabled && "Value2VPValue mapping may be out of date!");
+ assert((Value2VPValueEnabled || !VPV->getDefiningRecipe()) &&
+ "Value2VPValue mapping may be out of date!");
----------------
Ayal wrote:
> nit: an isLiveIn() method may be clearer than these !getDefiningRecipe()'s.
Done in 3157f03a349cfc852cdd994675eaa9652caa2e3a, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147892/new/
https://reviews.llvm.org/D147892
More information about the llvm-commits
mailing list