[PATCH] D149068: [llvm-mca][RISCV] Fix checking if data valid in createInstrument
Michael Maitland via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 24 09:11:26 PDT 2023
michaelmaitland added a comment.
> Though I'm a little surprised it doesn't print a warning or even error for invalid instruments. Is there any reason behind this?
Debug warning is printed on line 85 of `RISCVCustomBehaviour.cpp`. We print an actual error and exit from MCA here <https://github.com/llvm/llvm-project/blob/53791896de3fcc5606c190fa4e4552383ee1dcb8/llvm/tools/llvm-mca/CodeRegionGenerator.cpp#L190>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149068/new/
https://reviews.llvm.org/D149068
More information about the llvm-commits
mailing list