[PATCH] D148986: [InstSimplify] with logical ops: (X | Y) ? 0 : X --> 0

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Implementation looks good, can you please precommit the tests?



================
Comment at: llvm/test/Transforms/InstSimplify/select-cmp-or.ll:33
+;
+  %a = mul i32 %a0, 43         ; thwart complexity-based canonicalization
+  %or = or i32 %a, %b
----------------
Not needed for instsimplify tests.


================
Comment at: llvm/test/Transforms/InstSimplify/select-cmp-or.ll:60
+  ret i32 %cond
+}
----------------
Could you please add a negative test where the icmp constant is not zero?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148986/new/

https://reviews.llvm.org/D148986