[PATCH] D149061: [clang] remove dereferencing of invalid pointer

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 06:43:47 PDT 2023


DavidSpickett added a comment.

Seems fine to me, that is what size is for after all :). Just one comment.



================
Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:2333
   void printLeft(OutputBuffer &OB) const override {
     const char *first = &*Contents.begin();
     const size_t N = FloatData<Float>::mangled_size;
----------------
Might as well merge this into the `const char* t = ` line below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149061/new/

https://reviews.llvm.org/D149061



More information about the llvm-commits mailing list