[PATCH] D148821: [SystemZ][z/OS] Create utility functions for converting between EBCDIC and UTF-8.

[Corentin Jabot via Phabricator via llvm-commits]

cor3ntin added inline comments.


================
Comment at: llvm/lib/Support/ConvertEBCDIC.cpp:75
+  size_t Length = Source.size();
+  Result.clear();
+  while (Length--) {
----------------
I think I'd prefer to assert `Result` is empty
also, I think we should do something like `Result.reserve(Source.size())` to minimize allocations in the common case


================
Comment at: llvm/lib/Support/ConvertEBCDIC.cpp:106
+  size_t Length = Source.size();
+  Result.clear();
+  while (Length--) {
----------------
Same comment as above


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148821/new/

https://reviews.llvm.org/D148821