[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

Mon Apr 24 04:48:42 PDT 2023

TIFitis marked 3 inline comments as done.
TIFitis added inline comments.

================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1491
+            mapTypes = exitDataOp.getMapTypes();
+            mapperFunc = false;
+            return success();
----------------
mehdi_amini wrote:
> This line is not needed after the fix you pushed right?
> 
> Seems like we could also just set `bool mapperFunc = isa<omp::EnterDataOp>(op);` or something like that.
I've already removed this line in my fix.

Yes, I think we can get rid of the variable altogether and just pass the `isa` as an argument when calling. I'll add this change in one of my ongoing patches.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142914/new/

https://reviews.llvm.org/D142914