[PATCH] D149025: [sanitizer][asan][win] Only unmap unneeded shadow memory on x86_64

Mon Apr 24 04:42:58 PDT 2023

mstorsjo added a comment.

In D149025#4291611 <https://reviews.llvm.org/D149025#4291611>, @alvinhochun wrote:

> In D149025#4290881 <https://reviews.llvm.org/D149025#4290881>, @mstorsjo wrote:
>
>> However for MSVC, the `GetHeapSizeTest` test still fails in `check-asan`
>
> I think I know what's going on here -- if you compiled the tests before applying the patch, then applied the patch and reran `ninja check-asan`, the tests don't actually get relinked.The static asan libs are linked in by `-fsanitize=address`, so CMake does not have any idea about the dependency on the static asan libs. You have to manually trigger a change, like touch one of the test source, to get the tests to be relinked using the rebuilt static asan.
>
> On my MSVC test setup these tests do pass with this change. (Admittedly I also was confused when reverting the change didn't cause the tests to fail at first.)

Oh, thanks, you're right! By forcing it to relink those executables, the tests do pass now. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149025/new/

https://reviews.llvm.org/D149025