[PATCH] D148905: [Vectorize] Fix vectorization, scalarization and folding of llvm.is.fpclass

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:485
+    SmallVector<Type *, 2> TysForDecl;
+    if (isVectorIntrinsicWithOverloadTypeAtArg(VectorIntrinsicID, -1)) {
+      TysForDecl.push_back(
----------------
Could you add a comment here with an explanation? I.e. we are adding the return type if the intrinsic is overloaded on it.

Might be good to add this in all updated places in the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148905/new/

https://reviews.llvm.org/D148905