[PATCH] D141823: [SCEV] More precise trip multiples

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:14341
+  for (auto [S, Multiple] : ConstantMultipleCache) {
+    APInt RecomputedMultiple = SE2.getConstantMultipleImpl(S);
+    if (Multiple != RecomputedMultiple) {
----------------
mkazantsev wrote:
> caojoshua wrote:
> > nikic wrote:
> > > Hm, can this end up modifying the map we're iterating?
> > I think its possible. I'm going to revert this change and investigate later. Looks like buildbot is failing 027a4c8b96c7f97df8e98b1dac069b956810ab94.
> `SE2` is a different entity, so how could it?
Oh yeah, good point. I missed that this is on SE2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141823/new/

https://reviews.llvm.org/D141823