[PATCH] D148980: [X86] Machine combine vnni instruction.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCombiner.cpp:426
   unsigned NewRootLatency, RootLatency;
-  std::tie(NewRootLatency, RootLatency) =
-      getLatenciesForInstrSequences(*Root, InsInstrs, DelInstrs, BlockTrace);
+  if (TII->accumulateInstrSeqToRootLatency(*Root))
+    std::tie(NewRootLatency, RootLatency) =
----------------
Put curly braces around the if body for consistency with the else body.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:9791
+  unsigned Opc = Root.getOpcode();
+  unsigned VpAddOpc;
+  unsigned VpMaddOpc;
----------------
The Vp prefix on these variable names isn't providing much value. You can probably drop it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148980/new/

https://reviews.llvm.org/D148980