[PATCH] D146974: [test] A test case for D146958

Sun Apr 23 14:34:32 PDT 2023

fhahn added inline comments.

================
Comment at: llvm/test/Transforms/LoopVectorize/vector-no-scevcheck.ll:15
+  %mul0 = mul nsw i64 %i, %val2
+  %arrayidx0 = getelementptr inbounds double, ptr %0, i64 %mul0
+  %mul1 = mul nsw i64 %i, %val1
----------------
pawosm01 wrote:
> fhahn wrote:
> > Could you add a new function that's basically the same as `@foo` but has `%arrayidx0` in `%loop2.header`?
> > Could you add a new function that's basically the same as @foo but has %arrayidx0 in %loop2.header?
> 
> This will not expose the same behavior of the D146958 patch we care about in this test (namely, `vector.scevcheck` will remain).
> 
Right, but that's only with the current version of the patch; it should be relatively straightforward to also handle this case (https://reviews.llvm.org/D146958#inline-1439048). In any case, it won't hurt to have negative test cases as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146974/new/

https://reviews.llvm.org/D146974