[PATCH] D146958: [SCEV] Do not plant SCEV checks unnecessarily

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2566
+  // sense to add it here.
+  if (TheLoop->isLoopInvariant(Ptr))
+    return;
----------------
Better use a more powerful SCEV based check that the AddRec for the ptr is for `TheLoop` ( check `TheLoop  != AR->getLoop()` in `getStrideFromPointer`)



================
Comment at: llvm/lib/Analysis/VectorUtils.cpp:1163
+      // sense to add it here.
+      if (TheLoop->isLoopInvariant(Ptr))
+        continue;
----------------
Is this needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146958/new/

https://reviews.llvm.org/D146958