[PATCH] D149027: [X86] Add peephole to convert `(Cmp Op32/Op64, Imm8)` -> `(Cmp Op16/Op8, Imm8)`

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:5653
+          MVT NewVT;
+          if(CurDAG->MaskedValueIsZero(
+                 N0, APInt::getBitsSetFrom(OpVT.getScalarSizeInBits(), 8)))
----------------
craig.topper wrote:
> Space after if
Shouldn't we check that OpVT.getScalarSizeInBits() is more than 8 bits before calling MaskedValueIsZero?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149027/new/

https://reviews.llvm.org/D149027