[PATCH] D149025: [sanitizer][asan][win] Only unmap unneeded shadow memory on x86_64

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 23 13:43:52 PDT 2023


mstorsjo added a comment.

I think this is reasonable. I didn't follow the explanation in the description in detail, but I think it sounds reasonable. This does fix running `check-asan-dynamic` on both MSVC and MinGW in i386 mode (for MinGW, on top of the other patches that are currently in review). However for MSVC, the `GetHeapSizeTest` test still fails in `check-asan`:

  Failed Tests (2):
    AddressSanitizer-Unit :: ./Asan-i386-calls-Test.exe/AddressSanitizerInterface/GetHeapSizeTest
    AddressSanitizer-Unit :: ./Asan-i386-inline-Test.exe/AddressSanitizerInterface/GetHeapSizeTest


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149025/new/

https://reviews.llvm.org/D149025



More information about the llvm-commits mailing list