[PATCH] D149027: [X86] Add peephole to convert `(Cmp Op32/Op64, Imm8)` -> `(Cmp Op16/Op8, Imm8)`

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 23 12:33:25 PDT 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/test/CodeGen/X86/vector-reduce-and-cmp.ll:691
 ; AVX-NEXT:    vmovd %xmm0, %eax
-; AVX-NEXT:    cmpw $-1, %ax
+; AVX-NEXT:    cmpw $65535, %ax # imm = 0xFFFF
 ; AVX-NEXT:    sete %al
----------------
RKSimon wrote:
> This looks suspicous?
I think its from the `C.trunc(NewVT.getScalarSizeInBits()).getZExtValue()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149027/new/

https://reviews.llvm.org/D149027



More information about the llvm-commits mailing list