[PATCH] D146718: [LV] Add tests for integer min max with index reduction pattern. (NFC)

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/Transforms/LoopVectorize/smax-idx.ll:1
+; RUN: opt -passes=loop-vectorize -force-vector-width=4 -force-vector-interleave=1 -debug-only=loop-vectorize,iv-descriptors -S < %s 2>&1 | FileCheck %s --check-prefix=CHECK
+; RUN: opt -passes=loop-vectorize -force-vector-width=4 -force-vector-interleave=4 -debug-only=loop-vectorize,iv-descriptors -S < %s 2>&1 | FileCheck %s --check-prefix=CHECK
----------------
this doesn't check any debug output, so maybe remove `-debug-only=`?  If it needs to check debug output, this needs `REQUIRES: asserts` otherwise it will fail with assertions disabled (which removes `debug-only` support.


================
Comment at: llvm/test/Transforms/LoopVectorize/smax-idx.ll:13
+for.body:
+  %indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
+  %max.09 = phi i64 [ %mm, %entry ], [ %1, %for.body ]
----------------
nit: remove unnecessary `indvars` prefix.


================
Comment at: llvm/test/Transforms/LoopVectorize/smax-idx.ll:42
+  %indvars.iv = phi i64 [ 0, %entry ], [ %indvars.iv.next, %for.body ]
+  %idx.011 = phi i64 [ %ii, %entry ], [ %spec.select7, %for.body ]  ;;
+  %max.09 = phi i64 [ %mm, %entry ], [ %1, %for.body ]              ;;
----------------
stray `;;` at end?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146718/new/

https://reviews.llvm.org/D146718