[PATCH] D149021: [TTI][ASAN] Introduce TTI::getInterstingMemoryOperand.

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 23 09:52:47 PDT 2023


arichardson added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:32
 #include "llvm/Support/InstructionCost.h"
+#include "llvm/Transforms/Instrumentation/AddressSanitizerCommon.h"
 #include <functional>
----------------
This looks like a layering violation? I don't think analysis can depend on this?


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:2296
+  InterestingMemoryOperand
+  getInterstingMemoryOperand(IntrinsicInst *II) const override {
+    return Impl.getInterstingMemoryOperand(II);
----------------
Missing e here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149021/new/

https://reviews.llvm.org/D149021



More information about the llvm-commits mailing list