[PATCH] D149022: [LLD][COFF] Print object file name for unsupported directives

[Alvin Wong via Phabricator via llvm-commits]

alvinhochun created this revision.
alvinhochun added reviewers: hans, rnk, mstorsjo.
Herald added a project: All.
alvinhochun requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is a small QoL improvement suggested by FrancescElies in
https://github.com/llvm/llvm-project/issues/56300#issuecomment-1172104966.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149022

Files:
  lld/COFF/Driver.cpp
  lld/test/COFF/directives-unsupported.s


Index: lld/test/COFF/directives-unsupported.s
===================================================================
--- /dev/null
+++ lld/test/COFF/directives-unsupported.s
@@ -0,0 +1,15 @@
+# REQUIRES: x86
+
+# RUN: llvm-mc -triple=x86_64-windows %s -filetype=obj -o %t.obj
+
+# RUN: not lld-link -dll -out:%t.dll -entry:entry %t.obj -subsystem:console 2>&1 | FileCheck --ignore-case %s
+
+# CHECK: warning: ignoring unknown argument: -unknowndirectivename
+# CHECK: error: -unknowndirectivename is not allowed in .drectve ({{.*}}.obj)
+
+  .global entry
+  .text
+entry:
+  ret
+  .section .drectve
+  .ascii " -unknowndirectivename "
Index: lld/COFF/Driver.cpp
===================================================================
--- lld/COFF/Driver.cpp
+++ lld/COFF/Driver.cpp
@@ -447,7 +447,7 @@
     case OPT_throwingnew:
       break;
     default:
-      error(arg->getSpelling() + " is not allowed in .drectve");
+      error(arg->getSpelling() + " is not allowed in .drectve (" + toString(file) + ")");
     }
   }
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149022.516173.patch
Type: text/x-patch
Size: 1025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230423/763624ca/attachment.bin>