[PATCH] D149012: [InstSimplify] Test case for D149001

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 23 01:32:17 PDT 2023


nikic added a comment.

In D149012#4290315 <https://reviews.llvm.org/D149012#4290315>, @floatshadow wrote:

> In D149012#4290292 <https://reviews.llvm.org/D149012#4290292>, @nikic wrote:
>
>> The tests in this patch should have baseline check lines, i.e. generated using LLVM built without your patch.
>
> Thank you for you reply! This my first revision and I misunderstood the meaning of "baseline check"
>
> This means I should first update the diff of test IRs in this baseline check revision without my patch, i.e. output IR should be the same as input IR;  
> then apply my patch to the code and expect we would gain optimizations, i.e. output IR optimized and differ from input IR?
> Is this correct?

Yes, exactly!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149012/new/

https://reviews.llvm.org/D149012



More information about the llvm-commits mailing list