[PATCH] D148413: [InstCombine] Remove requirement on `trunc` in `slt/sgt` case in `foldSelectICmpAndOr`

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 23 01:17:53 PDT 2023


nikic added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/select-with-bitwise-ops.ll:772
   ret i8 %select
 }
 
----------------
Can you add a multi-use variant of this test? I think the reason why this code is checking for the trunc is that it replaces a one-use trunc with an and, which preserves the number of uses. If we drop the check, we'll have to take NeedsAnd into account when counting uses.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148413/new/

https://reviews.llvm.org/D148413



More information about the llvm-commits mailing list