[PATCH] D147734: [LV][NFC] Precommit test for a follow-up patch that introduces uniformity for a specific VF.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 22 13:38:08 PDT 2023


fhahn added a comment.

Thanks for adding all the extra tests! For the multi-induction tests, I think it would be good to have the additional `iv2` also used in the loop body (besides incrementing it) in some of the tests, as suggested inline.



================
Comment at: llvm/test/Transforms/LoopVectorize/uniform_across_vf_induction2.ll:54
+loop:
+  %iv2 = phi i64 [ 0, %entry ], [ %iv2_next, %loop ]
+  %iv = phi i64 [ 0, %entry ], [ %iv_next, %loop ]
----------------
for those tests, it would probably be good to use `%iv2` as well, possibly some cases where the index is `%iv /C + iv2 / C`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147734/new/

https://reviews.llvm.org/D147734



More information about the llvm-commits mailing list