[PATCH] D148980: [X86] Machine combine vnni instruction.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:9822
+      DelInstrs.push_back(&Root);
+      break;
+    }
----------------
goldstein.w.n wrote:
> LuoYuanke wrote:
> > goldstein.w.n wrote:
> > > Maybe this belongs in `X86FixupInstTuning.cpp`?
> > The method is to override the virtual function of TargetInstrInfo. 
> > X86FixupInstTuning.cpp may be integrated to MachineCombine.
> It seems.you are just querying for an opcode and replacing 1-1? Not that it can only be done in X86Fixup... But seems to fit there with less code.
It’s replacing 1 instruction with 2 after doing analysis that consults the scheduling model.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148980/new/

https://reviews.llvm.org/D148980