[PATCH] D149002: [compiler-rt][interception][win] Improve error reporting

Alvin Wong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 22 11:38:03 PDT 2023


alvinhochun created this revision.
alvinhochun added a reviewer: vitalybuka.
Herald added subscribers: Enna1, dberris.
Herald added a project: All.
alvinhochun requested review of this revision.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.

If an unrecoverable error occured when intercepting functions, print a
message before terminating.

Additionally, do not treat unknown instructions as a fatal error. Change
it so that a more helpful message containing the address and the bytes
of the unknown instruction is printed to help identify the issue. In
most cases, failure to intercept a function is also reported by the
caller, though requires setting verbosity to 1 or higher to be visible.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149002

Files:
  compiler-rt/lib/interception/interception_win.cpp
  compiler-rt/lib/interception/tests/CMakeLists.txt
  compiler-rt/lib/interception/tests/interception_win_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149002.516092.patch
Type: text/x-patch
Size: 5806 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230422/4231ed51/attachment.bin>


More information about the llvm-commits mailing list