[PATCH] D148963: [X86] Support `X86ISD::PCMPEQ` and `X86ISD::PCMPGT` in ComputeKnownBits

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 22 02:06:20 PDT 2023


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

Nice! LGTM with one minor



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:38573
+        DAG.computeKnownBits(Op.getOperand(1), DemandedElts, Depth + 1);
+    auto Res = Opc == X86ISD::PCMPEQ ? KnownBits::eq(KnownLhs, KnownRhs)
+                                     : KnownBits::sgt(KnownLhs, KnownRhs);
----------------
(style) Don't use auto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148963/new/

https://reviews.llvm.org/D148963



More information about the llvm-commits mailing list