[PATCH] D148906: [AMDGPU] Remove incompatible attributes of function in amdgpu-remove-incompatible-functions pass

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

In D148906#4287243 <https://reviews.llvm.org/D148906#4287243>, @yaxunl wrote:

> device libs may be linked in by other programs or libraries, e.g. comgr.

That used to be broken. Clang mlink-builtin-bitcode applies attributes to functions in device libs that were both required and missing from device libs. Caused a bunch of pain in openmp because we really wanted to link device libs at link time, not into every TU up front in clang. Has someone fixed that requirement?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148906/new/

https://reviews.llvm.org/D148906