[PATCH] D148876: [IndirectCallPromotion] Clear value profile metadata after the last run of indirect-call-promotion in a pipeline

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 21 15:34:14 PDT 2023


wenlei added a comment.

> Thanks for the explanation. IIUC, the fix for SimplyCFG dropping !VP is to either block the corresponding optimization or to merge the !VP data when merge callsites. What is the problem of always merging callsite !VP?

@hoy the problem is you lose flow-sensitivity for the VP after merge. And since ICP is important, it perhaps warrant special handling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148876/new/

https://reviews.llvm.org/D148876



More information about the llvm-commits mailing list