[PATCH] D146753: [llvm-readobj] Include section information in summary

[Paul Kirth via Phabricator via llvm-commits]

paulkirth added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:7771-7790
   std::vector<EnumEntry<unsigned>> FlagsList =
       getSectionFlagsForTarget(this->Obj.getHeader().e_ident[ELF::EI_OSABI],
                                this->Obj.getHeader().e_machine);
   for (const Elf_Shdr &Sec : cantFail(this->Obj.sections())) {
     ++TotalSections;
     TotalSize += Sec.sh_size;
     if (Sec.sh_flags & SHF_ALLOC) {
----------------
ikudrin wrote:
> It looks like you forget to include the actual patch in the review.
Indeed. I had forgotten to squash my commit when uploading. This should be fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146753/new/

https://reviews.llvm.org/D146753