[PATCH] D148955: [Object] Always initialized StartOfFile in Archive::Child::Child constructor.

[Jacek Caban via Phabricator via llvm-commits]

jacek created this revision.
jacek added reviewers: jhenderson, efriedma.
Herald added a subscriber: hiraditya.
Herald added a project: All.
jacek requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fixes uninitialized memory access revealed by https://reviews.llvm.org/D146534.

In empty archives, we use Child(nullptr,nullptr,nullptr) in Archive constructor in setFirstRegular. This copies unitialized StartOfFile to FirstRegularStartOfFile, which child_begin may use later.


https://reviews.llvm.org/D148955

Files:
  llvm/lib/Object/Archive.cpp


Index: llvm/lib/Object/Archive.cpp
===================================================================
--- llvm/lib/Object/Archive.cpp
+++ llvm/lib/Object/Archive.cpp
@@ -468,6 +468,7 @@
     : Parent(Parent) {
   if (!Start) {
     Header = nullptr;
+    StartOfFile = -1;
     return;
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148955.515893.patch
Type: text/x-patch
Size: 294 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230421/a4c270d0/attachment.bin>