[PATCH] D148876: [IndirectCallPromotion] Clear value profile metadata after the last run of indirect-call-promotion in a pipeline

[Mingming Liu via Phabricator via llvm-commits]

mingmingl planned changes to this revision.
mingmingl added a comment.

In D148876#4288286 <https://reviews.llvm.org/D148876#4288286>, @tejohnson wrote:

> Would be good to explain motivation (maybe reference other patch?)

Makes sense, will do.

> Also, the new tests only test the behavior with the internal option. It would be good to have tests with various pipelines to check the logic on when it gets cleared in those different cases simply based on the new pipeline logic.

I see your point. I'm going to write a test like https://github.com/llvm/llvm-project/blob/main/llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll to test pipeline logic.

In D148876#4288429 <https://reviews.llvm.org/D148876#4288429>, @wenlei wrote:

> cc @hoy to make sure this works for csspgo.

thanks! The assumption here is that ICP runs once per pipeline and there are no other passes that uses value-profiles. If the assumption doesn't hold, I'm thinking about an explicit boolean in ICP pass constructor (which makes pipeline logic a little bit more complex)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148876/new/

https://reviews.llvm.org/D148876