[PATCH] D147544: [BOLT] Move from RuntimeDyld to JITLink

[Rafael Auler via Phabricator via llvm-commits]

rafauler added a comment.

I think I forgot to clarify this: when I mentioned nondeterminism when running the terminator insertion pass, I meant same binary, same inputs, same everything, but getting different outputs from run to run.  I meant:

$  ninja check-bolt
87 tests failed

Then again
$ ninja check-bolt
84 tests failed

without changing anything.

Also, to be clear, I never intend to commit this (to use the null insertion pass), this is just for validation purposes. I can try to pad eh_frame to have the same size as before in another way. I was just curious why is that happening, but didn't have time to look into it.

But another source of non-determinism that we can't have is iteration over DenseMaps, because those change if we build a new version of BOLT and cause a bunch of headaches when we are qualifying a new release.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147544/new/

https://reviews.llvm.org/D147544