[PATCH] D148045: [NFC][Symbolizer] Refactor out MarkupContext
Daniel Thornburgh via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 21 11:47:44 PDT 2023
mysterymath added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/Symbolize/MarkupContext.h:37
+/// module-relative addresses.
+class MarkupContext {
+public:
----------------
phosek wrote:
> Do you think it'd be more descriptive to name this class `ProcessContext`?
I like this a lot. It was a bit strange that llvm-objump referred to markup in the patch at the end of the stack; just calling these process contexts makes markup one way to produce them, but frees up the possibiliy for others.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148045/new/
https://reviews.llvm.org/D148045
More information about the llvm-commits
mailing list